lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3 2/5] dt-bindings: i2c: Add bindings for i2c-virtio
On Mon, Jul 26, 2021 at 10:06 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Mon, Jul 26, 2021 at 6:52 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > This patch adds binding for virtio I2C device, it is based on
> > virtio-device bindings.
> >
> > Acked-by: Wolfram Sang <wsa@kernel.org>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Too quick, after seeing the same issue in the gpio binding I saw it here too:

> + i2c-virtio {
> + compatible = "virtio,22";

The node name "i2c-virtio" looks wrong. According to
https://github.com/devicetree-org/dt-schema/blob/master/schemas/i2c/i2c-controller.yaml,
this needs to be plain "i2c".

Arnd

\
 
 \ /
  Last update: 2021-07-26 10:14    [W:0.064 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site