lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] genirq/affinity: add helper of irq_affinity_calc_sets
On Tue, Jul 20, 2021 at 09:50:25AM +0200, Christoph Hellwig wrote:
> > +int irq_affinity_calc_sets(unsigned int affvecs, struct irq_affinity *affd)
> > +{
> > + /*
> > + * Simple invocations do not provide a calc_sets() callback. Call
> > + * the generic one.
> > + */
> > + if (!affd->calc_sets)
> > + default_calc_sets(affd, affvecs);
> > + else
> > + affd->calc_sets(affd, affvecs);
>
> Nit: avoid pointless negations:
>
> if (affd->calc_sets)
> affd->calc_sets(affd, affvecs);
> else
> default_calc_sets(affd, affvecs);

+1

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks for doing this! For the PCI part:

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

\
 
 \ /
  Last update: 2021-07-21 02:05    [W:0.036 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site