Messages in this thread | | | From | "Zhuo, Qiuxu" <> | Subject | RE: [PATCH 3/7] EDAC/mc: Add new HBM2 memory type | Date | Tue, 20 Jul 2021 12:13:37 +0000 |
| |
> From: Luck, Tony <tony.luck@intel.com> > ... > That commit makes the normal vs. HBM error visible in the DIMM label (by > prefixing the "MC" for memory controller with "HB". > > + if (imc->hbm_mc) > + snprintf(dimm->label, sizeof(dimm->label), > "CPU_SrcID#%u_HBMC#%u_Chan#%u", > + imc->src_id, imc->lmc, chan); > + else > + snprintf(dimm->label, sizeof(dimm->label), > "CPU_SrcID#%u_MC#%u_Chan#%u_DIMM#%u", > + imc->src_id, imc->lmc, chan, dimmno); > > Perhaps we should also set the "type" of the DIMMs. Qiuxu: opinion?
Yes, we should. I'll make a patch for it.
Thanks! -Qiuxu
| |