Messages in this thread | | | Date | Tue, 20 Jul 2021 13:45:57 +0300 | From | Mike Rapoport <> | Subject | Re: [PATCH v14 023/138] mm/swap: Add folio_rotate_reclaimable() |
| |
On Thu, Jul 15, 2021 at 04:35:09AM +0100, Matthew Wilcox (Oracle) wrote: > Convert rotate_reclaimable_page() to folio_rotate_reclaimable(). This > eliminates all five of the calls to compound_head() in this function, > saving 75 bytes at the cost of adding 15 bytes to its one caller, > end_page_writeback(). We also save 36 bytes from pagevec_move_tail_fn() > due to using folios there. Net 96 bytes savings. > > Also move its declaration to mm/internal.h as it's only used by filemap.c. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Acked-by: Vlastimil Babka <vbabka@suse.cz> > Reviewed-by: William Kucharski <william.kucharski@oracle.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > --- > include/linux/swap.h | 1 - > mm/filemap.c | 3 ++- > mm/internal.h | 1 + > mm/page_io.c | 4 ++-- > mm/swap.c | 30 ++++++++++++++++-------------- > 5 files changed, 21 insertions(+), 18 deletions(-)
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
| |