lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/6] remoteproc: k3-dsp: Refactor mbox request code in start
    On Fri, May 21, 2021 at 07:03:08PM -0500, Suman Anna wrote:
    > Refactor out the mailbox request and associated ping logic code
    > from k3_dsp_rproc_start() function into its own separate function
    > so that it can be re-used in the soon to be added .attach() ops
    > callback.
    >
    > Signed-off-by: Suman Anna <s-anna@ti.com>
    > ---
    > drivers/remoteproc/ti_k3_dsp_remoteproc.c | 65 ++++++++++++++---------
    > 1 file changed, 39 insertions(+), 26 deletions(-)

    Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

    >
    > diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
    > index fd4eb67a6681..faf60a274e8d 100644
    > --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
    > +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
    > @@ -216,6 +216,43 @@ static int k3_dsp_rproc_release(struct k3_dsp_rproc *kproc)
    > return ret;
    > }
    >
    > +static int k3_dsp_rproc_request_mbox(struct rproc *rproc)
    > +{
    > + struct k3_dsp_rproc *kproc = rproc->priv;
    > + struct mbox_client *client = &kproc->client;
    > + struct device *dev = kproc->dev;
    > + int ret;
    > +
    > + client->dev = dev;
    > + client->tx_done = NULL;
    > + client->rx_callback = k3_dsp_rproc_mbox_callback;
    > + client->tx_block = false;
    > + client->knows_txdone = false;
    > +
    > + kproc->mbox = mbox_request_channel(client, 0);
    > + if (IS_ERR(kproc->mbox)) {
    > + ret = -EBUSY;
    > + dev_err(dev, "mbox_request_channel failed: %ld\n",
    > + PTR_ERR(kproc->mbox));
    > + return ret;
    > + }
    > +
    > + /*
    > + * Ping the remote processor, this is only for sanity-sake for now;
    > + * there is no functional effect whatsoever.
    > + *
    > + * Note that the reply will _not_ arrive immediately: this message
    > + * will wait in the mailbox fifo until the remote processor is booted.
    > + */
    > + ret = mbox_send_message(kproc->mbox, (void *)RP_MBOX_ECHO_REQUEST);
    > + if (ret < 0) {
    > + dev_err(dev, "mbox_send_message failed: %d\n", ret);
    > + mbox_free_channel(kproc->mbox);
    > + return ret;
    > + }
    > +
    > + return 0;
    > +}
    > /*
    > * The C66x DSP cores have a local reset that affects only the CPU, and a
    > * generic module reset that powers on the device and allows the DSP internal
    > @@ -273,37 +310,13 @@ static int k3_dsp_rproc_unprepare(struct rproc *rproc)
    > static int k3_dsp_rproc_start(struct rproc *rproc)
    > {
    > struct k3_dsp_rproc *kproc = rproc->priv;
    > - struct mbox_client *client = &kproc->client;
    > struct device *dev = kproc->dev;
    > u32 boot_addr;
    > int ret;
    >
    > - client->dev = dev;
    > - client->tx_done = NULL;
    > - client->rx_callback = k3_dsp_rproc_mbox_callback;
    > - client->tx_block = false;
    > - client->knows_txdone = false;
    > -
    > - kproc->mbox = mbox_request_channel(client, 0);
    > - if (IS_ERR(kproc->mbox)) {
    > - ret = -EBUSY;
    > - dev_err(dev, "mbox_request_channel failed: %ld\n",
    > - PTR_ERR(kproc->mbox));
    > + ret = k3_dsp_rproc_request_mbox(rproc);
    > + if (ret)
    > return ret;
    > - }
    > -
    > - /*
    > - * Ping the remote processor, this is only for sanity-sake for now;
    > - * there is no functional effect whatsoever.
    > - *
    > - * Note that the reply will _not_ arrive immediately: this message
    > - * will wait in the mailbox fifo until the remote processor is booted.
    > - */
    > - ret = mbox_send_message(kproc->mbox, (void *)RP_MBOX_ECHO_REQUEST);
    > - if (ret < 0) {
    > - dev_err(dev, "mbox_send_message failed: %d\n", ret);
    > - goto put_mbox;
    > - }
    >
    > boot_addr = rproc->bootaddr;
    > if (boot_addr & (kproc->data->boot_align_addr - 1)) {
    > --
    > 2.30.1
    >

    \
     
     \ /
      Last update: 2021-06-02 18:05    [W:2.457 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site