lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v1 1/2] gpio: dwapb: Drop redundant check in dwapb_irq_set_type()
    On Tue, Jun 1, 2021 at 6:21 PM Andy Shevchenko
    <andriy.shevchenko@linux.intel.com> wrote:
    >
    > For more than 15 years we may not get into ->irq_set_type()
    > without any meaningful type provided.
    >
    > Drop redundant check in dwapb_irq_set_type().
    >
    > See the commit e76de9f8eb67 ("[PATCH] genirq: add SA_TRIGGER support")
    > out of curiosity.
    >
    > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    > ---
    > drivers/gpio/gpio-dwapb.c | 3 ---
    > 1 file changed, 3 deletions(-)
    >
    > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
    > index d3233cc4b76b..939701c1465e 100644
    > --- a/drivers/gpio/gpio-dwapb.c
    > +++ b/drivers/gpio/gpio-dwapb.c
    > @@ -297,9 +297,6 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type)
    > irq_hw_number_t bit = irqd_to_hwirq(d);
    > unsigned long level, polarity, flags;
    >
    > - if (type & ~IRQ_TYPE_SENSE_MASK)
    > - return -EINVAL;
    > -
    > spin_lock_irqsave(&gc->bgpio_lock, flags);
    > level = dwapb_read(gpio, GPIO_INTTYPE_LEVEL);
    > polarity = dwapb_read(gpio, GPIO_INT_POLARITY);
    > --
    > 2.30.2
    >

    Applied, thanks!

    Bart

    \
     
     \ /
      Last update: 2021-06-02 15:37    [W:2.964 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site