Messages in this thread | | | From | Ulf Hansson <> | Date | Wed, 2 Jun 2021 15:17:13 +0200 | Subject | Re: [PATCH v5 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver |
| |
On Wed, 2 Jun 2021 at 13:24, Anup Patel <anup.patel@wdc.com> wrote: > > The generic power domain related code in PSCI domain driver is largely > independent of PSCI and can be shared with RISC-V SBI domain driver > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > Signed-off-by: Anup Patel <anup.patel@wdc.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
A small nitpick below.
[...]
> +EXPORT_SYMBOL_GPL(dt_idle_pd_free);
Do we really need to export this symbol? Looks like there are only built-in cpuidle drivers that are going to use it. At least for now.
As a matter of fact, the same comment applies to all cases of EXPORT_SYMBOL_GPL from $subject patch. Can we drop all of them?
[...]
Kind regards Uffe
| |