lkml.org 
[lkml]   [2021]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 答复 : [PATCH net-next] net: mdio: Fix a typo
On Wed, Jun 02, 2021 at 07:43:19AM +0000, zhengyongjun wrote:
> Russell King told me to do so... Did I understand it wrong?
> But from your opinion, I think "Hz" is more appropriate :)

Sadly, you understood wrong. I requested to change from hz to Hz.

> ```
> Russell King <linux@armlinux.org.uk>
>
> On Tue, Jun 01, 2021 at 10:18:59PM +0800, Zheng Yongjun wrote:
> > informations ==> information
> > typicaly ==> typically
> > derrive ==> derive
> > eventhough ==> even though
>
> If you're doing this, then please also change "hz" to "Hz". The unit of frequency is the latter, not the former. Thanks.
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
> ```
>
> -----邮件原件-----
> 发件人: Joe Perches [mailto:joe@perches.com]
> 发送时间: 2021年6月2日 15:25
> 收件人: zhengyongjun <zhengyongjun3@huawei.com>; andrew@lunn.ch; hkallweit1@gmail.com; davem@davemloft.net; kuba@kernel.org; bcm-kernel-feedback-list@broadcom.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> 抄送: opendmb@gmail.com; f.fainelli@gmail.com; linux@armlinux.org.uk
> 主题: Re: [PATCH net-next] net: mdio: Fix a typo
>
> On Wed, 2021-06-02 at 14:39 +0800, Zheng Yongjun wrote:
> > Hz ==> hz
> []
> > diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c
> []
> > @@ -203,7 +203,7 @@ static void unimac_mdio_clk_set(struct unimac_mdio_priv *priv)
> >   return;
> >   }
> >
> > - /* The MDIO clock is the reference clock (typically 250MHz) divided by
> > + /* The MDIO clock is the reference clock (typically 250Mhz) divided by
>
> No thanks.
>
> MHz is typical, Mhz is not.
>
> $ git grep -w -i -o -h mhz | sort |uniq -c | sort -rn
> 5042 MHz
> 571 MHZ
> 398 Mhz
> 353 mhz
> 10 mHz
>
>

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

\
 
 \ /
  Last update: 2021-06-02 12:08    [W:3.368 / U:1.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site