Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] powerpc/8xx: select CPM1 for MPC8XXFADS | From | Christophe Leroy <> | Date | Wed, 2 Jun 2021 09:44:15 +0200 |
| |
Le 01/06/2021 à 19:53, trix@redhat.com a écrit : > From: Tom Rix <trix@redhat.com> > > With MPC8XXFADS, there is this linker error > ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade': > m8xx_setup.c: undefined reference to `cpm_get_irq'
It looks like this config item is stale, it doesn't build any board support, there is no define_machine() for this config item, no file is linked to that config item.
I think you should just remove that item from the possible choices.
Christophe
> > cpm_get_irq() is conditionally complied by CPM1 > So add a select, like the other plaforms > > Signed-off-by: Tom Rix <trix@redhat.com> > --- > arch/powerpc/platforms/8xx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/8xx/Kconfig b/arch/powerpc/platforms/8xx/Kconfig > index 60cc5b537a98..919082cdb2f1 100644 > --- a/arch/powerpc/platforms/8xx/Kconfig > +++ b/arch/powerpc/platforms/8xx/Kconfig > @@ -10,6 +10,7 @@ choice > > config MPC8XXFADS > bool "FADS" > + select CPM1 > > config MPC86XADS > bool "MPC86XADS" >
| ![\](/images/icornerr.gif) |