Messages in this thread | | | Subject | Re: [PATCH] ACPI: tables: fixes the missed acpi_put_table() in acpi_init_fpdt() | From | Zhang Rui <> | Date | Wed, 02 Jun 2021 15:28:02 +0800 |
| |
Hi, Xiangfeng,
thanks for the patch.
On Wed, 2021-06-02 at 09:17 +0800, Jing Xiangfeng wrote: > acpi_init_fpdt() misses to call acpi_put_table() in an error path. > Add > the missed function call to fix it. > > Fixes: d1eb86e59be0 ("ACPI: tables: introduce support for FPDT > table") > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Acked-by: Zhang Rui <rui.zhang@intel.com>
thanks, rui > --- > drivers/acpi/acpi_fpdt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c > index a89a806a7a2a..4ee2ad234e3d 100644 > --- a/drivers/acpi/acpi_fpdt.c > +++ b/drivers/acpi/acpi_fpdt.c > @@ -240,8 +240,10 @@ static int __init acpi_init_fpdt(void) > return 0; > > fpdt_kobj = kobject_create_and_add("fpdt", acpi_kobj); > - if (!fpdt_kobj) > + if (!fpdt_kobj) { > + acpi_put_table(header); > return -ENOMEM; > + } > > while (offset < header->length) { > subtable = (void *)header + offset;
| |