Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH][next] null_blk: Fix null pointer dereference on nullb->disk on blk_cleanup_disk call | Date | Thu, 3 Jun 2021 00:00:15 +0000 |
| |
On 6/2/21 03:07, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The error handling on a nullb->disk allocation currently jumps to > out_cleanup_disk that calls blk_cleanup_disk with a null pointer causing > a null pointer dereference issue. Fix this by jumping to out_cleanup_tags > instead. > > Addresses-Coverity: ("Dereference after null check") > Fixes: 132226b301b5 ("null_blk: convert to blk_alloc_disk/blk_cleanup_disk") > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
| |