Messages in this thread | | | Subject | Re: [PATCH 7/7] pwm: ep93xx: Prepare clock before using it | From | Alexander Sverdlin <> | Date | Mon, 14 Jun 2021 09:30:08 +0200 |
| |
Hi Uwe!
On Mon, 2021-06-14 at 09:22 +0200, Uwe Kleine-König wrote: > > Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch > > to Common Clock Framework. > > > > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@gmail.com> > > Maybe it would make sense to move the prepare into the probe function?!
If one thinks about real meaningful clk_prepare(), not like in EP93xx, then clk_is_enabled_when_prepared() shall be considered and this might change behaviour. That's why this "stupid" approach was chosen for this conversion. Also, unfortunately, I don't have a test setup for PWM, this made me shy towards this driver ;)
-- Alexander Sverdlin.
| |