lkml.org 
[lkml]   [2021]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] x86/mm/mtrr: fix doc warnings in generic.c
On Sat, Jun 05, 2021 at 02:48:21PM +0800, Baokun Li wrote:
> @@ -104,7 +104,8 @@ static int check_type_overlap(u8 *prev, u8 *curr)
>
> /**
> * mtrr_type_lookup_fixed - look up memory type in MTRR fixed entries
> - *
> + * @start: Start addaress.

addaress?

Spellchecker?

> + * @end: End address.
> * Return the MTRR fixed memory type of 'start'.
> *
> * MTRR fixed entries are divided into the following ways:
> @@ -143,7 +144,11 @@ static u8 mtrr_type_lookup_fixed(u64 start, u64 end)
>
> /**
> * mtrr_type_lookup_variable - look up memory type in MTRR variable entries
> - *
> + * @start: Start addaress.

addaress?

Spellchecker?

> + * @end: End address.
> + * @partial_end: Partial end address.
> + * @repeat: Memory is repeat or not.
> + * @uniform: Memory is uniform or not.

Did you actually read that whole comment to see that maybe "repeat" and
"uniform" are explained a bit further down or are you blindly "fixing"
warnings just so that the tool shuts up?

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2021-06-10 09:37    [W:7.147 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site