Messages in this thread | | | Date | Wed, 5 May 2021 07:19:58 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v6 2/4] leds: Add driver for Qualcomm LPG |
| |
Hello again,
another feedback that only came to me after hitting "Send": It might be sensible to split the patch. In the first part add the LED stuff and in the second the PWM stuff.
It would also be good if the PWM code could live in drivers/pwm.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |