Messages in this thread | | | Date | Fri, 30 Apr 2021 09:26:09 +0200 | From | Oleksij Rempel <> | Subject | Re: [PATCH net-next v3 3/6] net: add generic selftest support |
| |
Hi Geert,
On Fri, Apr 30, 2021 at 08:45:05AM +0200, Geert Uytterhoeven wrote: > Hi Oleksij, > > On Mon, Apr 19, 2021 at 3:13 PM Oleksij Rempel <o.rempel@pengutronix.de> wrote: > > Port some parts of the stmmac selftest and reuse it as basic generic selftest > > library. This patch was tested with following combinations: > > - iMX6DL FEC -> AT8035 > > - iMX6DL FEC -> SJA1105Q switch -> KSZ8081 > > - iMX6DL FEC -> SJA1105Q switch -> KSZ9031 > > - AR9331 ag71xx -> AR9331 PHY > > - AR9331 ag71xx -> AR9331 switch -> AR9331 PHY > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > Thanks for your patch, which is now commit 3e1e58d64c3d0a67 ("net: add > generic selftest support") upstream. > > > --- a/net/Kconfig > > +++ b/net/Kconfig > > @@ -429,6 +429,10 @@ config GRO_CELLS > > config SOCK_VALIDATE_XMIT > > bool > > > > +config NET_SELFTESTS > > + def_tristate PHYLIB > > Why does this default to enabled if PHYLIB=y? > Usually we allow the user to make selftests modular, independent of the > feature under test, but I may misunderstand the purpose of this test. > > Thanks for your clarification!
There is nothing against making optional. Should I do it?
Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |