lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/12] perf inject: Add --vm-time-correlation option
    On Thu, Apr 29, 2021 at 03:58:47PM +0300, Adrian Hunter wrote:
    > evsel->handler = drop_sample;
    > }
    >
    > +static int parse_vm_time_correlation(const struct option *opt, const char *str, int unset)
    > +{
    > + struct perf_inject *inject = opt->value;
    > + const char *args;
    > + char *dry_run;
    > +
    > + if (unset)
    > + return 0;
    > +
    > + inject->itrace_synth_opts.set = true;
    > + inject->itrace_synth_opts.vm_time_correlation = true;
    > + inject->in_place_update = true;
    > +
    > + if (!str)
    > + return 0;
    > +
    > + dry_run = strstr(str, "dry-run");

    Please use a proper split, otherwise it cannot be extended.

    Right now just !strcmp is enough I guess

    >

    \
     
     \ /
      Last update: 2021-04-29 20:47    [W:8.312 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site