lkml.org 
[lkml]   [2021]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5/7] Revert "regulator: tps65910: fix a missing check of return value"
    On Thu, Apr 29, 2021 at 03:08:09PM +0200, Greg Kroah-Hartman wrote:
    > This reverts commit cd07e3701fa6a4c68f8493ee1d12caa18d46ec6a.
    >
    > Commits from @umn.edu addresses have been found to be submitted in "bad
    > faith" to try to test the kernel community's ability to review "known
    > malicious" changes. The result of these submissions can be found in a
    > paper submitted to the 42nd IEEE Symposium on Security and Privacy
    > entitled, "Open Source Insecurity: Stealthily Introducing
    > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
    > of Minnesota) and Kangjie Lu (University of Minnesota) but later
    > withdrawn.
    >
    > Because of this, all submissions from this group must be reverted from
    > the kernel tree and will need to be re-reviewed again to determine if
    > they actually are a valid fix. Until that work is complete, remove this
    > change to ensure that no problems are being introduced into the
    > codebase.
    >
    > Cc: Kangjie Lu <kjlu@umn.edu>
    > Cc: Mark Brown <broonie@kernel.org>
    > ---
    > drivers/regulator/tps65910-regulator.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
    > index 1d5b0a1b86f7..8ad1ecc1559f 100644
    > --- a/drivers/regulator/tps65910-regulator.c
    > +++ b/drivers/regulator/tps65910-regulator.c
    > @@ -1098,10 +1098,8 @@ static int tps65910_probe(struct platform_device *pdev)
    > platform_set_drvdata(pdev, pmic);
    >
    > /* Give control of all register to control port */
    > - err = regmap_set_bits(pmic->mfd->regmap, TPS65910_DEVCTRL,
    > + regmap_set_bits(pmic->mfd->regmap, TPS65910_DEVCTRL,
    > DEVCTRL_SR_CTL_I2C_SEL_MASK);
    > - if (err < 0)
    > - return err;
    >
    > switch (tps65910_chip_id(tps65910)) {
    > case TPS65910:
    > --
    > 2.31.1
    >

    This looks correct to me, I'll drop the revert.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2021-04-29 15:47    [W:4.483 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site