| Subject | Re: [PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions | From | Tomi Valkeinen <> | Date | Fri, 23 Apr 2021 15:12:08 +0300 |
| |
On 16/04/2021 17:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/omapdrm/omap_irq.c:114: warning: expecting prototype for enable_vblank(). Prototype was for omap_irq_enable_vblank() instead > drivers/gpu/drm/omapdrm/omap_irq.c:140: warning: expecting prototype for disable_vblank(). Prototype was for omap_irq_disable_vblank() instead > > Cc: Tomi Valkeinen <tomba@kernel.org> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Rob Clark <rob.clark@linaro.org> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c > index 15148d4b35b57..dff095c864909 100644 > --- a/drivers/gpu/drm/omapdrm/omap_irq.c > +++ b/drivers/gpu/drm/omapdrm/omap_irq.c > @@ -99,7 +99,7 @@ int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable) > } > > /** > - * enable_vblank - enable vblank interrupt events > + * omap_irq_enable_vblank - enable vblank interrupt events > * @crtc: DRM CRTC > * > * Enable vblank interrupts for @crtc. If the device doesn't have > @@ -129,7 +129,7 @@ int omap_irq_enable_vblank(struct drm_crtc *crtc) > } > > /** > - * disable_vblank - disable vblank interrupt events > + * omap_irq_disable_vblank - disable vblank interrupt events > * @crtc: DRM CRTC > * > * Disable vblank interrupts for @crtc. If the device doesn't have >
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
|