Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH v5 1/5] dt-bindings: mfd: Initial commit of silergy,sy7636a.yaml | Date | Mon, 19 Apr 2021 08:11:03 -0500 |
| |
On Mon, 19 Apr 2021 07:02:18 +1000, Alistair Francis wrote: > Initial support for the Silergy SY7636A Power Management chip > and regulator. > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > --- > v5: > - Improve the documentation > > .../bindings/mfd/silergy,sy7636a.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml: properties:regulators:properties:$ref: '/schemas/regulator/regulator.yaml#' is not of type 'object', 'boolean' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml: properties:regulators:properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for '$ref' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml: properties:regulators:properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml: ignoring, error in schema: properties: regulators: properties: $ref warning: no schema found in file: ./Documentation/devicetree/bindings/mfd/silergy,sy7636a.yaml Documentation/devicetree/bindings/mfd/silergy,sy7636a.example.dt.yaml:0:0: /example-0/i2c/pmic@62: failed to match any schema with compatible: ['silergy,sy7636a'] Documentation/devicetree/bindings/mfd/silergy,sy7636a.example.dt.yaml:0:0: /example-0/i2c/pmic@62/regulators: failed to match any schema with compatible: ['silergy,sy7636a-regulator']
See https://patchwork.ozlabs.org/patch/1467830
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |