Messages in this thread Patch in this message | | | Subject | Re: [PATCH] base: power: runtime.c: Remove a unnecessary space | From | Joe Perches <> | Date | Sun, 18 Apr 2021 02:22:35 -0700 |
| |
On Sun, 2021-04-18 at 09:11 +0000, Sebastian Fricke wrote: > Hey Joe,
Hi Sebastian.
> On 18.04.2021 00:09, Joe Perches wrote: > > On Sun, 2021-04-18 at 06:08 +0000, Sebastian Fricke wrote: > > > Remove a redundant space to improve the quality of the comment. > > I think this patch is not useful. > > It's not redundant. > > Thank you, I actually found this pattern a few more times but I wanted > to check first if this is a mistake or chosen consciously. [] > > For drivers/base/power/runtime.c, that 2 space after period style is used > > dozens of times and changing a single instance of it isn't very useful.
Even in that single file it's not consistent. It's something like 3:1 for 2 spaces over 1 space after period.
I believe it's done more by habit and author age than anything. If you learned to type using a typewriter and not a keyboard, then you likely still use 2 spaces after a period.
> True and if I understand you correctly you would rather keep it as is > right?
Yes. IMO: Whitespace in comments like this should not be changed unless there's some other significant benefit like better alignment.
cheers, Joe
> > > --- > > > Side-note: > > > I found this while reading the code, I don't believe it is important but > > > I thought it doesn't hurt to fix it. [] > > > diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c [] > > > @@ -786,7 +786,7 @@ static int rpm_resume(struct device *dev, int rpmflags) > > > } > > > > > > /* > > > - * See if we can skip waking up the parent. This is safe only if > > > + * See if we can skip waking up the parent. This is safe only if > > > * power.no_callbacks is set, because otherwise we don't know whether > > > * the resume will actually succeed. > > > */
| |