Messages in this thread | | | Subject | Re: [PATCH v2] tools: do not include scripts/Kbuild.include | From | Paolo Bonzini <> | Date | Fri, 16 Apr 2021 15:27:39 +0200 |
| |
On 16/04/21 15:26, Christian Borntraeger wrote: > > > On 16.04.21 15:00, Masahiro Yamada wrote: >> Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to >> scripts/Makefile.compiler"), some kselftests fail to build. >> >> The tools/ directory opted out Kbuild, and went in a different >> direction. They copy any kind of files to the tools/ directory >> in order to do whatever they want in their world. >> >> tools/build/Build.include mimics scripts/Kbuild.include, but some >> tool Makefiles included the Kbuild one to import a feature that is >> missing in tools/build/Build.include: >> >> - Commit ec04aa3ae87b ("tools/thermal: tmon: use "-fstack-protector" >> only if supported") included scripts/Kbuild.include from >> tools/thermal/tmon/Makefile to import the cc-option macro. >> >> - Commit c2390f16fc5b ("selftests: kvm: fix for compilers that do >> not support -no-pie") included scripts/Kbuild.include from >> tools/testing/selftests/kvm/Makefile to import the try-run macro. >> >> - Commit 9cae4ace80ef ("selftests/bpf: do not ignore clang >> failures") included scripts/Kbuild.include from >> tools/testing/selftests/bpf/Makefile to import the .DELETE_ON_ERROR >> target. >> >> - Commit 0695f8bca93e ("selftests/powerpc: Handle Makefile for >> unrecognized option") included scripts/Kbuild.include from >> tools/testing/selftests/powerpc/pmu/ebb/Makefile to import the >> try-run macro. >> >> Copy what they need into tools/build/Build.include, and make them >> include it instead of scripts/Kbuild.include. >> >> Link: >> https://lore.kernel.org/lkml/86dadf33-70f7-a5ac-cb8c-64966d2f45a1@linux.ibm.com/ >> >> Fixes: d9f4ff50d2aa ("kbuild: spilt cc-option and friends to >> scripts/Makefile.compiler") >> Reported-by: Janosch Frank <frankja@linux.ibm.com> >> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com> >> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > looks better. > Tested-by: Christian Borntraeger <borntraeger@de.ibm.com> >
Thank you very much Masahiro, this look great.
Paolo
| |