lkml.org 
[lkml]   [2021]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
Date
On Tuesday, March 2, 2021 9:46:04 AM EDT you wrote:
> On Thu, Feb 25, 2021 at 9:33 AM Julian Braha <julianbraha@gmail.com> wrote:
>
> > When PINCTRL_MSM is enabled, and GPIOLIB is disabled,
> > Kbuild gives the following warning:
> >
> > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP
> > Depends on [n]: GPIOLIB [=n]
> > Selected by [y]:
> > - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y])
> >
> > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP,
> > without selecting or depending on GPIOLIB, despite
> > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM
> > select GPIOLIB will cause a recursive dependency error.
> >
> > Signed-off-by: Julian Braha <julianbraha@gmail.com>
>
> Does it work to just:
>
> select GPIOLIB
>
> instead?
>
> The driver needs the library so...
>
> Yours,
> Linus Walleij
>

Hi Linus,

Looks like I confused this patch with another one when
I responded last time. This config option cannot select
GPIOLIB, because it will cause a recursive dependency
error.

Any other ideas?

- Julian Braha



\
 
 \ /
  Last update: 2021-03-29 18:44    [W:0.150 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site