lkml.org 
[lkml]   [2021]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH next v3 11/15] printk: kmsg_dumper: remove @active field
On Thu 2021-02-25 21:24:34, John Ogness wrote:
> All 6 kmsg_dumpers do not benefit from the @active flag:
>
> (provide their own synchronization)
> - arch/powerpc/kernel/nvram_64.c
> - arch/um/kernel/kmsg_dump.c
> - drivers/mtd/mtdoops.c
> - fs/pstore/platform.c
>
> (only dump on KMSG_DUMP_PANIC, which does not require
> synchronization)
> - arch/powerpc/platforms/powernv/opal-kmsg.c
> - drivers/hv/vmbus_drv.c
>
> The other 2 kmsg_dump users also do not rely on @active:
>
> (hard-code @active to always be true)
> - arch/powerpc/xmon/xmon.c
> - kernel/debug/kdb/kdb_main.c

Great summary!

> Therefore, @active can be removed.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

\
 
 \ /
  Last update: 2021-03-01 21:55    [W:0.292 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site