lkml.org 
[lkml]   [2021]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB
    Hi Fabrizio,

    Thank you for the patch.

    On Thu, Feb 25, 2021 at 10:51:43PM +0000, Fabrizio Castro wrote:
    > Document bindings for R-Car DAB hardware accelerator, currently
    > found on the r8a77990 SoC (a.k.a. R-Car E3) and on the r8a77965
    > SoC (a.k.a. R-Car M3-N).
    >
    > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
    > ---
    > .../devicetree/bindings/misc/renesas,dab.yaml | 75 +++++++++++++++++++
    > 1 file changed, 75 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/misc/renesas,dab.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/misc/renesas,dab.yaml b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
    > new file mode 100644
    > index 000000000000..e9494add13d7
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/misc/renesas,dab.yaml
    > @@ -0,0 +1,75 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +# Copyright (C) 2021 Renesas Electronics Corporation
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/misc/renesas,dab.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Renesas R-Car DAB Hardware Accelerator
    > +
    > +maintainers:
    > + - Fabrizio Castro <fabrizio.castro.jz@renesas.com>
    > +
    > +description:
    > + The DAB hardware accelerator found on some R-Car devices is a hardware
    > + accelerator for software DAB demodulators.
    > + It consists of one FFT (Fast Fourier Transform) module and one decoder module,
    > + compatible with DAB specification (ETSI EN 300 401 and ETSI TS 102 563).
    > + The decoder module can perform FIC decoding and MSC decoding processing from
    > + de-puncture to final decoded result.
    > +
    > +properties:
    > + compatible:
    > + items:
    > + - enum:
    > + - renesas,dab-r8a77965 # R-Car M3-N
    > + - renesas,dab-r8a77990 # R-Car E3
    > + - const: renesas,rcar-gen3-dab # Generic fallback for R-Car Gen3 devices
    > +
    > + reg:
    > + maxItems: 1
    > +
    > + interrupts:
    > + maxItems: 1
    > +
    > + clocks:
    > + maxItems: 1
    I usually try to describe clocks:

    clocks:
    items:
    - description: The module functional clock

    but as there's a single clock, it may not be worth it. Up to you.

    > +
    > + clock-names:
    > + const: dab

    With Geert's and Sergei's comments addressed,

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > +
    > + power-domains:
    > + maxItems: 1
    > +
    > + resets:
    > + maxItems: 1
    > +
    > +required:
    > + - compatible
    > + - reg
    > + - interrupts
    > + - clocks
    > + - clock-names
    > + - power-domains
    > + - resets
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + # R8A77990 (R-Car E3)
    > + - |
    > + #include <dt-bindings/clock/r8a77990-cpg-mssr.h>
    > + #include <dt-bindings/interrupt-controller/arm-gic.h>
    > + #include <dt-bindings/power/r8a77990-sysc.h>
    > +
    > + dab: dab@e6730000 {
    > + compatible = "renesas,dab-r8a77990",
    > + "renesas,rcar-gen3-dab";
    > + reg = <0xe6730000 0x120>;
    > + interrupts = <GIC_SPI 160 IRQ_TYPE_LEVEL_HIGH>;
    > + clocks = <&cpg CPG_MOD 1016>;
    > + clock-names = "dab";
    > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
    > + resets = <&cpg 1016>;
    > + status = "disabled";
    > + };

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2021-02-26 14:05    [W:4.139 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site