lkml.org 
[lkml]   [2021]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH 22/24] KVM: x86/mmu: Use is_removed_spte() instead of open coded equivalents
    From
    Use the is_removed_spte() helper instead of open coding the check.

    No functional change intended.

    Cc: Ben Gardon <bgardon@google.com>
    Signed-off-by: Sean Christopherson <seanjc@google.com>
    ---
    arch/x86/kvm/mmu/tdp_mmu.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/x86/kvm/mmu/tdp_mmu.c b/arch/x86/kvm/mmu/tdp_mmu.c
    index bef0e1908e82..7f2c4760b84d 100644
    --- a/arch/x86/kvm/mmu/tdp_mmu.c
    +++ b/arch/x86/kvm/mmu/tdp_mmu.c
    @@ -490,7 +490,7 @@ static inline bool tdp_mmu_set_spte_atomic(struct kvm *kvm,
    * Do not change removed SPTEs. Only the thread that froze the SPTE
    * may modify it.
    */
    - if (iter->old_spte == REMOVED_SPTE)
    + if (is_removed_spte(iter->old_spte))
    return false;

    if (cmpxchg64(rcu_dereference(iter->sptep), iter->old_spte,
    @@ -565,7 +565,7 @@ static inline void __tdp_mmu_set_spte(struct kvm *kvm, struct tdp_iter *iter,
    * should be used. If operating under the MMU lock in write mode, the
    * use of the removed SPTE should not be necessary.
    */
    - WARN_ON(iter->old_spte == REMOVED_SPTE);
    + WARN_ON(is_removed_spte(iter->old_spte));

    WRITE_ONCE(*rcu_dereference(iter->sptep), new_spte);

    --
    2.30.1.766.gb4fecdf3b7-goog
    \
     
     \ /
      Last update: 2021-02-25 22:05    [W:4.061 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site