Messages in this thread | | | Date | Thu, 25 Feb 2021 20:09:35 +0200 | From | Mike Rapoport <> | Subject | Re: [PATCH v7 1/1] mm/page_alloc.c: refactor initialization of struct page for holes in memory layout |
| |
On Thu, Feb 25, 2021 at 09:54:34AM -0800, Linus Torvalds wrote: > On Thu, Feb 25, 2021 at 9:07 AM Mike Rapoport <rppt@linux.ibm.com> wrote: > > > > > > > > We might still double-initialize PFNs when two zones overlap within a > > > section, correct? > > > > You mean that a section crosses zones boundary? > > I don't think it's that important. > > What if there was a memory allocation in between that could allocate > the once-initialized page?
Can't happen because this code runs before any allocation is possible and it is single threaded.
> Maybe it can't happen, or is not an issue for some other reason, but > this code has been fragile and had a ton of subtle issues, so maybe > worth documenting (or explaining here why it's just not relevant)
Ok, I'll do another pass on the comments in the code.
> Linus
-- Sincerely yours, Mike.
| |