Messages in this thread | | | From | Masahiro Yamada <> | Date | Fri, 26 Feb 2021 01:17:58 +0900 | Subject | Re: [GIT PULL] Modules updates for v5.12 |
| |
On Fri, Feb 26, 2021 at 12:49 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > On Thu, Feb 25, 2021 at 4:36 AM Rasmus Villemoes > <rasmus.villemoes@prevas.dk> wrote: > > > > On 24/02/2021 15.40, Masahiro Yamada wrote: > > > On Wed, Feb 24, 2021 at 5:33 PM Jessica Yu <jeyu@kernel.org> wrote: > > >> > > >> +++ Linus Torvalds [23/02/21 12:03 -0800]: > > >>> On Tue, Feb 23, 2021 at 12:01 PM Christoph Hellwig <hch@lst.de> wrote: > > >>>> > > >>>> Does your build now enable TRIM_UNUSED_KSYMS but previously didn't by > > >>>> chance? > > >>> > > >>> Crossed emails. > > >>> > > >>> This is plain "make allmodconfig", so yes, now it will enable TRIM_UNUSED_KSYMS. > > >>> > > >>> This is unacceptably slow. If that symbol trimming takes 30% of the > > >>> whole kernel build time, it needs to be fixed or removed. > > >> > > >> [ Adding Masahiro to CC ] > > >> > > >> It looks like CONFIG_TRIM_UNUSED_KSYMS had been hiding behind > > >> CONFIG_UNUSED_SYMBOLS all this time, and once the EXPORT_UNUSED_SYMBOL > > >> stuff was removed, it exposed that option to be selected by > > >> allyesconfig. That option had previously caused build issues on > > >> powerpc on linux-next, so I had temporarily marked that as BROKEN on > > >> powerpc until Masahiro's fix landed in linux-next. I was not aware of > > >> the additional build slowdown issue :/ In any case, Christoph's > > >> suggestion to invert the option sounds reasonable, since the mips > > >> defconfig selects it, it does not seem totally unused. > > > Good insight. > Actually, I came up with the same idea last night, and had started > the implementation background. > I needed sleep before completing the patch set, but > now it is working as far as I tested. > > BTW, > KEEP(*(SORT(___ksymtab+foo ___ksymtab+bar ___ksymtab+baz)) > is a syntax error. > > KEEP(*(__ksymtab+foo)) > KEEP(*(__ksymtab+bar)) > KEEP(*(__ksymtab+baz)) > > works. > >
Sorry, I missed to CC you.
This patch set.
https://lore.kernel.org/patchwork/project/lkml/list/?series=486545
-- Best Regards Masahiro Yamada
| |