Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 25 Feb 2021 13:18:21 +0100 | Subject | Re: [PATCH] x86: mark some mpspec inline functions as __init |
| |
On Thu, Feb 25, 2021 at 12:45 PM Borislav Petkov <bp@alien8.de> wrote: > On Thu, Feb 25, 2021 at 12:22:41PM +0100, Arnd Bergmann wrote:
> > -static inline void get_smp_config(void) > > +static inline __init void get_smp_config(void) > > __always_inline then I guess. > > Not inlining those is just silly.
Either way works correctly, I don't care much, but picked the __init annotation as it seemed more intuitive. If the compiler decides to make it out-of-line for whatever reason, I see no point in telling it otherwise, even though I agree it is a bit silly.
Should I send the patch with __always_inline?
Arnd
| |