lkml.org 
[lkml]   [2021]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] regulator: add missing call to of_node_put()
Hi,

thanks for reporting this, you're right but you've missed the braces
around the if block in your patch, because we really want to exit
only on -ENOMEM. Something like:

if (ret == -ENOMEM) {
of_node_put(child);
return ret;
}

Regards,

Cristian

On Thu, Feb 25, 2021 at 05:07:26PM +0800, Yang Li wrote:
> In one of the error paths of the for_each_child_of_node() loop,
> add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/regulator/scmi-regulator.c:343:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return around
> line 347.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/regulator/scmi-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/scmi-regulator.c b/drivers/regulator/scmi-regulator.c
> index 0e8b3ca..a41bb06 100644
> --- a/drivers/regulator/scmi-regulator.c
> +++ b/drivers/regulator/scmi-regulator.c
> @@ -344,6 +344,7 @@ static int scmi_regulator_probe(struct scmi_device *sdev)
> ret = process_scmi_regulator_of_node(sdev, child, rinfo);
> /* abort on any mem issue */
> if (ret == -ENOMEM)
> + of_node_put(child);
> return ret;
> }
>
> --
> 1.8.3.1
>

\
 
 \ /
  Last update: 2021-02-25 13:07    [W:0.026 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site