lkml.org 
[lkml]   [2021]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 2/9] ALSA: virtio: add virtio sound driver
On Thu, 25 Feb 2021 11:38:35 +0100,
Takashi Iwai wrote:
>
> On Mon, 22 Feb 2021 16:34:37 +0100,
> Anton Yakovlev wrote:
> > +static int virtsnd_find_vqs(struct virtio_snd *snd)
> > +{
> > + struct virtio_device *vdev = snd->vdev;
> > + vq_callback_t *callbacks[VIRTIO_SND_VQ_MAX] = {
> > + [VIRTIO_SND_VQ_EVENT] = virtsnd_event_notify_cb
> > + };
> > + const char *names[VIRTIO_SND_VQ_MAX] = {
>
> Shouldn't be static?

Also callbacks[] should be static (and maybe const), I suppose.


Takashi

\
 
 \ /
  Last update: 2021-02-25 11:53    [W:0.075 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site