Messages in this thread | | | Date | Fri, 26 Feb 2021 09:38:07 +0800 | From | Shuo A Liu <> | Subject | Re: [PATCH] virt: acrn: add hotplug_cpu dependency |
| |
Hi Arnd,
There is already a patchset for this build issue. Please refer to https://lore.kernel.org/lkml/20210221134339.57851-1-shuo.a.liu@intel.com/.
Hi Greg, Would you like accept that patchset in you tree?
Thanks shuo
On Thu 25.Feb'21 at 14:38:30 +0100, Arnd Bergmann wrote: >From: Arnd Bergmann <arnd@arndb.de> > >Without CPU hotplug, acrn fails to build: > >drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function 'remove_cpu' [-Werror,-Wimplicit-function-declaration] > remove_cpu(cpu); > ^ >drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function 'add_cpu' [-Werror,-Wimplicit-function-declaration] > add_cpu(cpu); > ^ > >Enforce the dependency through Kconfig to avoid the build failure. > >Fixes: 666834c47d3b ("virt: acrn: Introduce ACRN HSM basic driver") >Signed-off-by: Arnd Bergmann <arnd@arndb.de> >--- > drivers/virt/acrn/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/virt/acrn/Kconfig b/drivers/virt/acrn/Kconfig >index 3e1a61c9d8d8..fbb0e3234aaf 100644 >--- a/drivers/virt/acrn/Kconfig >+++ b/drivers/virt/acrn/Kconfig >@@ -2,6 +2,7 @@ > config ACRN_HSM > tristate "ACRN Hypervisor Service Module" > depends on ACRN_GUEST >+ depends on HOTPLUG_CPU > select EVENTFD > help > ACRN Hypervisor Service Module (HSM) is a kernel module which >-- >2.29.2 >
| |