Messages in this thread | | | Date | Thu, 25 Feb 2021 16:14:24 -0800 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz |
| |
On Thu, Feb 25, 2021 at 02:13:04PM -0800, Douglas Anderson wrote: > From: Alexandru M Stan <amstan@chromium.org> > > Removed the pinctrl and pin{mux,conf} for the control pins because: > 1. The only need for them is for userspace control via flash_fp_mcu > 2. cros-ec doesn't know what to do with them, and even if it did, > it would interfere with flash_fp_mcu at the most inopportune times > > Since we're not using hogs, we rely on AP firmware to set all the > control pins correctly. > > Cc: Stephen Boyd <swboyd@chromium.org> > Cc: Craig Hesling <hesling@chromium.org> > Signed-off-by: Alexandru M Stan <amstan@chromium.org> > [dianders: adjusted since coachz isn't upstream yet] > Signed-off-by: Douglas Anderson <dianders@chromium.org>
We have essentially the same patch downstream, so I suppose the AP FW indeed takes care of configuring the FP pins as needed :)
Reviewed-by; Matthias Kaehlcke <mka@chromium.org>
| |