lkml.org 
[lkml]   [2021]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [v8,4/7] PCI: mediatek-gen3: Add INTx support
From
Date
Hi Krzysztof,

Thanks for your review, I will fix it at next version.

On Wed, 2021-02-24 at 15:24 +0100, Krzysztof Wilczyński wrote:
> Hi Jianjun,
>
> [...]
> > +/**
> > + * mtk_intx_eoi
> > + * @data: pointer to chip specific data
> > + *
> > + * As an emulated level IRQ, its interrupt status will remain
> > + * until the corresponding de-assert message is received; hence that
> > + * the status can only be cleared when the interrupt has been serviced.
> > + */
> [...]
>
> See my comment about the kernel-doc from the following:
>
> https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/
>
> [...]
> > + if (err) {
> > + dev_err(dev, "failed to init PCIe IRQ domain\n");
> > + return err;
> > + }
> [...]
>
> Just a nitpick. What about using "initialize" in the above?
>
> Krzysztof

Thanks.

\
 
 \ /
  Last update: 2021-02-25 04:12    [W:0.528 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site