Messages in this thread | | | Subject | Re: [PATCH v3 1/2] dt-bindings: rng: bcm2835: document reset support | From | Álvaro Fernández Rojas <> | Date | Tue, 23 Feb 2021 21:48:32 +0100 |
| |
Hi Rob,
> El 23 feb 2021, a las 20:34, Rob Herring <robh@kernel.org> escribió: > > On Tue, 23 Feb 2021 18:00:05 +0100, Álvaro Fernández Rojas wrote: >> Some devices may need to perform a reset before using the RNG, such as the >> BCM6368. >> >> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> >> --- >> v3: make resets required if brcm,bcm6368-rng. >> v2: document reset support. >> >> .../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.example.dt.yaml: rng@10004180: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
I don’t get what’s wrong here...
> > See https://patchwork.ozlabs.org/patch/1443582 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
Best regards, Álvaro.
| |