Messages in this thread | | | Date | Tue, 23 Feb 2021 20:52:34 +0100 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH] memory: gpmc: fix out of bounds read and dereference on gpmc_cs[] |
| |
On Tue, Feb 23, 2021 at 07:38:21PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Currently the array gpmc_cs is indexed by cs before it cs is range checked > and the pointer read from this out-of-index read is dereferenced. Fix this > by performing the range check on cs before the read and the following > pointer dereference. > > Addresses-Coverity: ("Negative array index read") > Fixes: 186401937927 ("memory: gpmc: Move omap gpmc code to live under drivers") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/memory/omap-gpmc.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-)
Thanks, looks good. I'll take it after merge window.
Best regards, Krzysztof
| |