Messages in this thread | | | Subject | Re: [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot | From | Allen Pais <> | Date | Tue, 23 Feb 2021 21:56:13 +0530 |
| |
>>>> - /* >>>> - * Ask OP-TEE to free all cached shared memory objects to decrease >>>> - * reference counters and also avoid wild pointers in secure world >>>> - * into the old shared memory range. >>>> - */ >>>> - optee_disable_shm_cache(optee); >>>> + if (shutdown) { >>>> + optee_disable_shm_cache(optee); >>>> + } else { >>>> + /* >>>> + * Ask OP-TEE to free all cached shared memory >>>> + * objects to decrease reference counters and >>>> + * also avoid wild pointers in secure world >>>> + * into the old shared memory range. >>>> + */ >>>> + optee_disable_shm_cache(optee); >>> Calling optee_disable_shm_cache() in both if and else. It could be >>> put in front of if(). >>> >> >> Ideally, I could just use optee_remove for shutdown() too. >> But it would not look good. Hence this approach. > > What is the problem with using optee_remove() for shutdown()? >
There is no problem, I just thought it would be more cleaner/readable with this approach. If you'd like to keep it simple by just calling optee_remove() for shutdown() too, I could quickly send out V2.
Thanks for the review.
- Allen
| |