Messages in this thread | | | Subject | Re: [PATCH v1 1/4] dt-bindings: add bindings for rk3568 clock controller | From | Johan Jonker <> | Date | Tue, 23 Feb 2021 11:50:25 +0100 |
| |
Hi Elaine,
This is a new document. Could you convert rockchip,rk3568-cru.txt to yaml?
To get an acked-by you must include:
robh+dt@kernel.org devicetree@vger.kernel.org
./scripts/get_maintainer.pl --noroles --norolestats --nogit-fallback --nogit <patch>
Your patch should show up here after filtering: https://patchwork.ozlabs.org/project/devicetree-bindings/list/
Check with:
make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/pinctrl/rockchip,rk3568-cru.yaml
make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/pinctrl/rockchip,rk3568-cru.yaml
./scripts/checkpatch.pl --strict <patch>
On 2/23/21 10:53 AM, Elaine Zhang wrote: > Add devicetree bindings for Rockchip cru which found on > Rockchip SoCs. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > --- > .../bindings/clock/rockchip,rk3568-cru.txt | 66 +++++++++++++++++++ > 1 file changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.txt > > diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.txt b/Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.txt > new file mode 100644 > index 000000000000..b1119aecb7c7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3568-cru.txt > @@ -0,0 +1,66 @@ > +* Rockchip RK3568 Clock and Reset Unit > + > +The RK3568 clock controller generates and supplies clock to various > +controllers within the SoC and also implements a reset controller for SoC > +peripherals. > + > +Required Properties: > + > +- compatible: PMU for CRU should be "rockchip,rk3568-pmucru" > +- compatible: CRU should be "rockchip,rk3568-cru" > +- reg: physical base address of the controller and length of memory mapped > + region. > +- #clock-cells: should be 1. > +- #reset-cells: should be 1. > + > +Optional Properties: > + > +- rockchip,grf: phandle to the syscon managing the "general register files" > + If missing, pll rates are not changeable, due to the missing pll lock status. > + > +Each clock is assigned an identifier and client nodes can use this identifier > +to specify the clock which they consume. All available clocks are defined as > +preprocessor macros in the dt-bindings/clock/rk3568-cru.h headers and can be > +used in device tree sources. Similar macros exist for the reset sources in > +these files. > + > +External clocks: > + > +There are several clocks that are generated outside the SoC. It is expected > +that they are defined using standard clock bindings with following > +clock-output-names: > + - "xin24m" - crystal input - required, > + - "xin32k" - rtc clock - optional, > + - "i2sx_mclkin" - external I2S clock - optional, > + - "xin_osc0_usbphyx_g" - external USBPHY clock - optional, > + - "xin_osc0_mipidsiphyx_g" - external MIPIDSIPHY clock - optional, > + > +Example: Clock controller node: > + > + pmucru: clock-controller@fdd00000 { > + compatible = "rockchip,rK3568-pmucru"; > + reg = <0x0 0xfdd00000 0x0 0x1000>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + > + cru: clock-controller@fdd20000 { > + compatible = "rockchip,rK3568-cru"; > + reg = <0x0 0xfdd20000 0x0 0x1000>; > + rockchip,grf = <&grf>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + > +Example: UART controller node that consumes the clock generated by the clock > + controller: > + > + uart1: serial@fe650000 { > + compatible = "rockchip,rK3568-uart", "snps,dw-apb-uart"; > + reg = <0x0 0xfe650000 0x0 0x100>; > + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; > + reg-shift = <2>; > + reg-io-width = <4>; > + clocks = <&cru SCLK_UART1>, <&cru PCLK_UART1>; > + clock-names = "baudclk", "apb_pclk"; > + }; >
| |