lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mtd: nand: fix boolreturn.cocci warning
Hi Yihao,

hanyihao@vivo.com wrote on Mon, 6 Dec 2021 04:15:30 -0800:

> ./drivers/mtd/nand/core.c:25:9-10: WARNING: return of 0/1 in
> function 'nanddev_isbad' with return type bool
>
> Return statements in functions returning bool should use true/false
> instead of 1/0.

This is -next material, I want to have a clean branch there so I
applied this change inline, I hope you don't mind.

>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
> drivers/mtd/nand/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/core.c b/drivers/mtd/nand/core.c
> index 33c7788d76c2..416947f28b67 100644
> --- a/drivers/mtd/nand/core.c
> +++ b/drivers/mtd/nand/core.c
> @@ -22,7 +22,7 @@
> bool nanddev_isbad(struct nand_device *nand, const struct nand_pos *pos)
> {
> if (WARN_ONCE(mtd_expert_analysis_mode, mtd_expert_analysis_warning))
> - return 0;
> + return false;
>
> if (nanddev_bbt_is_initialized(nand)) {
> unsigned int entry;


Thanks,
Miquèl

\
 
 \ /
  Last update: 2021-12-09 17:54    [W:0.018 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site