Messages in this thread | | | Date | Thu, 9 Dec 2021 12:09:18 +0100 | From | José Expósito <> | Subject | Re: [PATCH] net: dsa: felix: Fix memory leak in felix_setup_mmio_filtering |
| |
On Wed, Dec 08, 2021 at 03:10:30PM -0800, Jakub Kicinski wrote: > On Wed, 8 Dec 2021 18:13:32 +0000 Vladimir Oltean wrote: > > Impossible memory leak, I might add, because DSA will error out much > > soon if there isn't any CPU port defined: > > https://elixir.bootlin.com/linux/v5.15.7/source/net/dsa/dsa2.c#L374 > > I don't think I should have added the "if (cpu < 0)" check at all, but > > then it would have raised other flags, about BIT(negative number) or > > things like that. I don't know what's the best way to deal with this? > > > > Anyway, in case we find no better alternative: > > > > Fixes: 8d5f7954b7c8 ("net: dsa: felix: break at first CPU port during init and teardown") > > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > If this is the way to go please repost with the tags added > and a commit message.
Thanks for the quick review. I just sent v2 in case you decide to keep the cpu check:
https://lore.kernel.org/netdev/20211209110538.11585-1-jose.exposito89@gmail.com/T/#u
Jose
| |