Messages in this thread | | | From | Vladimir Oltean <> | Subject | Re: [PATCH net-next v3 2/6] dt-bindings: net: lan966x: Extend with the analyzer interrupt | Date | Thu, 9 Dec 2021 10:58:58 +0000 |
| |
On Thu, Dec 09, 2021 at 10:46:11AM +0100, Horatiu Vultur wrote: > Extend dt-bindings for lan966x with analyzer interrupt. > This interrupt can be generated for example when the HW learn/forgets > an entry in the MAC table. > > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com> > ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Why don't you describe your hardware in the device tree all at once? Doing it piece by piece means that every time when you add a new functionality you need to be compatible with the absence of a certain reg, interrupt etc.
> .../devicetree/bindings/net/microchip,lan966x-switch.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > index 5bee665d5fcf..e79e4e166ad8 100644 > --- a/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > +++ b/Documentation/devicetree/bindings/net/microchip,lan966x-switch.yaml > @@ -37,12 +37,14 @@ properties: > items: > - description: register based extraction > - description: frame dma based extraction > + - description: analyzer interrupt > > interrupt-names: > minItems: 1 > items: > - const: xtr > - const: fdma > + - const: ana > > resets: > items: > -- > 2.33.0 >
| |