Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 9 Dec 2021 10:42:24 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH] dt-bindings: mtd: ti,gpmc-nand: Add missing 'rb-gpios' |
| |
Hi Rob,
robh@kernel.org wrote on Mon, 6 Dec 2021 11:42:09 -0600:
> With 'unevaluatedProperties' support implemented, the TI GPMC example > has a warning: > > Documentation/devicetree/bindings/memory-controllers/ti,gpmc.example.dt.yaml: nand@0,0: Unevaluated properties are not allowed ('rb-gpios' was unexpected) > > Add the missing definition for 'rb-gpios'.
rb-gpios is already defined in nand-controller.yaml. I seems like the real problem is that this file does not refer to it. Can you update the fix?
While at it you might also want to drop the rb-gpios property from ingenic,nand.yaml, which also defines it a second time.
> Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Vignesh Raghavendra <vigneshr@ti.com> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Roger Quadros <rogerq@kernel.org> > Cc: linux-mtd@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml > index beb26b9bcfb2..1c280f52baa0 100644 > --- a/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/ti,gpmc-nand.yaml > @@ -53,6 +53,11 @@ properties: > enum: [8, 16] > default: 8 > > + rb-gpios: > + description: > + GPIO connection to R/B signal from NAND chip > + maxItems: 1 > + > patternProperties: > "@[0-9a-f]+$": > $ref: "/schemas/mtd/partitions/partition.yaml"
Thanks, Miquèl
| ![\](/images/icornerr.gif) |