lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/3] block: don't delete queue kobject before its children
From
Date
On 12/9/21 3:17 PM, Eric Biggers wrote:
> On Thu, Dec 09, 2021 at 02:38:02PM -0800, Bart Van Assche wrote:
>> On 12/7/21 5:35 PM, Eric Biggers wrote:
>>> + /* Now that all child objects were deleted, the queue can be deleted. */
>>
>> Shouldn't the present tense be used above (were -> are)? Anyway:
>>
>> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
> "deleted" is an action here, not a state. I think it's fine as-is, but maybe
> you would prefer the following?
>
> /* Now that we've deleted all child objects, we can delete the queue. */

Both alternatives work for me.

Thanks,

Bart.

\
 
 \ /
  Last update: 2021-12-10 00:26    [W:0.024 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site