lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rdma-next 2/7] RDMA/mlx5: Replace cache list with Xarray
On Wed, Dec 08, 2021 at 12:46:11PM -0400, Jason Gunthorpe wrote:
> > @@ -166,14 +169,14 @@ static void create_mkey_callback(int status, struct mlx5_async_work *context)

<...>

> > static int resize_available_mrs(struct mlx5_cache_ent *ent, unsigned int target,
> > bool limit_fill)
> > + __acquires(&ent->lock) __releases(&ent->lock)
>
> Why?

This is mine, I got tons of complains from sparse [1] because of this commit [2].

[1] drivers/infiniband/hw/mlx5/mr.c:280:25: warning: context imbalance in 'resize_available_mkeys' - unexpected unlock
[2] https://lwn.net/Articles/109066/

Thanks

\
 
 \ /
  Last update: 2021-12-09 09:04    [W:0.032 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site