lkml.org 
[lkml]   [2021]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace
Hi!

> > + memzero_explicit(kaddr, dice_rmem->size);
> > + devm_memunmap(dice_misc.this_device, kaddr);
>
> Do you really need to call memzero_explicit()? This isn't "local"
> memory, if the compiler "optimizes away" a normal call, it would be
> _VERY_ broken.

For clearing secrets, I believe memzero_explicit is nice
documentation.

Best regards,
Pavel

--
http://www.livejournal.com/~pavelmachek
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-12-09 20:40    [W:0.062 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site