Messages in this thread | | | Date | Thu, 9 Dec 2021 20:38:57 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace |
| |
Hi!
> > + memzero_explicit(kaddr, dice_rmem->size); > > + devm_memunmap(dice_misc.this_device, kaddr); > > Do you really need to call memzero_explicit()? This isn't "local" > memory, if the compiler "optimizes away" a normal call, it would be > _VERY_ broken.
For clearing secrets, I believe memzero_explicit is nice documentation.
Best regards, Pavel
-- http://www.livejournal.com/~pavelmachek [unhandled content-type:application/pgp-signature] | |