Messages in this thread | | | Date | Thu, 9 Dec 2021 19:55:25 +0100 | Subject | Re: [PATCH v2] KVM: x86: Always set kvm_run->if_flag | From | Paolo Bonzini <> |
| |
On 12/9/21 19:29, Marc Orr wrote: > All that being said, after Jim added his Ack to this patch (which I > forgot to attach to the v2), we realized that technically the ES > patches were within their right to redefine if_flag since it's > previous semantics are maintained for non-ES VMs and ES requires > userspace changes anyway (PSP commands, guest memory pinning, etc.).
Correct, but it's a bit ugly to redefine the semantics and that is why I am going to apply the patch anyway.
Paolo
> I'm OK either way here. But I assume that if this flag is giving us > pains it will give others pains. And this patch seems reasonable to > me. So all things being equal, I'd prefer to proceed with it. >
| |