Messages in this thread | | | Date | Tue, 7 Dec 2021 21:16:27 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH] pyh: qcom: fix the application of sizeof to pointer |
| |
On Tue 07 Dec 17:03 PST 2021, davidcomponentone@gmail.com wrote:
> From: David Yang <davidcomponentone@gmail.com> > > The coccinelle check report: > ./drivers/phy/qualcomm/phy-qcom-edp.c:574:31-37: > ERROR: application of sizeof to pointer > > Using the real size to fix it. >
Thanks for the fix David.
Please see my answer here https://lore.kernel.org/all/Ya96KOynsO478cVx@ripper/
Regards, Bjorn
> Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Yang Guang <yang.guang5@zte.com.cn> > Signed-off-by: David Yang <davidcomponentone@gmail.com> > --- > drivers/phy/qualcomm/phy-qcom-edp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c > index 17d5653b661d..5fe4eab9cac1 100644 > --- a/drivers/phy/qualcomm/phy-qcom-edp.c > +++ b/drivers/phy/qualcomm/phy-qcom-edp.c > @@ -571,7 +571,7 @@ static int qcom_edp_clks_register(struct qcom_edp *edp, struct device_node *np) > struct clk_init_data init = { }; > int ret; > > - data = devm_kzalloc(edp->dev, sizeof(data), GFP_KERNEL); > + data = devm_kzalloc(edp->dev, sizeof(*data), GFP_KERNEL); > if (!data) > return -ENOMEM; > > -- > 2.30.2 >
| |