Messages in this thread | | | Date | Wed, 8 Dec 2021 09:03:16 +0200 | From | Leon Romanovsky <> | Subject | Re: [V2 2/6] driver core: auxiliary bus: Add driver data helpers |
| |
On Tue, Dec 07, 2021 at 09:14:44AM -0800, David E. Box wrote: > Adds get/set driver data helpers for auxiliary devices. > > Signed-off-by: David E. Box <david.e.box@linux.intel.com> > Reviewed-by: Mark Gross <markgross@kernel.org> > --- > V2 > - No changes > > include/linux/auxiliary_bus.h | 10 ++++++++++ > 1 file changed, 10 insertions(+)
I would really like to see an explanation why such obfuscation is really needed. dev_*_drvdata() is a standard way to access driver data.
Thanks
> > diff --git a/include/linux/auxiliary_bus.h b/include/linux/auxiliary_bus.h > index fc51d45f106b..a8338d456e81 100644 > --- a/include/linux/auxiliary_bus.h > +++ b/include/linux/auxiliary_bus.h > @@ -28,6 +28,16 @@ struct auxiliary_driver { > const struct auxiliary_device_id *id_table; > }; > > +static inline void *auxiliary_get_drvdata(struct auxiliary_device *auxdev) > +{ > + return dev_get_drvdata(&auxdev->dev); > +} > + > +static inline void auxiliary_set_drvdata(struct auxiliary_device *auxdev, void *data) > +{ > + dev_set_drvdata(&auxdev->dev, data); > +} > + > static inline struct auxiliary_device *to_auxiliary_dev(struct device *dev) > { > return container_of(dev, struct auxiliary_device, dev); > -- > 2.25.1 >
| |