lkml.org 
[lkml]   [2021]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] thermal/drivers/int340x: fix: update VCoRefLow MMIO bit offset for read
On Tue, Dec 7, 2021 at 1:36 PM Sumeet Pawnikar
<sumeet.r.pawnikar@intel.com> wrote:
>
> As part of RFIM validation, found that the register definition VCoRefLow
> of the CPU FIVR registers are different. Current implementation reads it
> from MMIO offset 0x5A18 and bit offset [12:14]. But the actual correct
> register definition is from bit offset [11:13]. Updated to the correct
> bit offset.
>
> Fixes: 473be51142ad ("thermal: int340x: processor_thermal: Add RFIM driver")
> Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar@intel.com>
> Cc: stable@vger.kernel.org # 5.14+
> ---
> drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c
> index b25b54d4bac1..e693ec8234fb 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_rfim.c
> @@ -29,7 +29,7 @@ static const char * const fivr_strings[] = {
> };
>
> static const struct mmio_reg tgl_fivr_mmio_regs[] = {
> - { 0, 0x5A18, 3, 0x7, 12}, /* vco_ref_code_lo */
> + { 0, 0x5A18, 3, 0x7, 11}, /* vco_ref_code_lo */
> { 0, 0x5A18, 8, 0xFF, 16}, /* vco_ref_code_hi */
> { 0, 0x5A08, 8, 0xFF, 0}, /* spread_spectrum_pct */
> { 0, 0x5A08, 1, 0x1, 8}, /* spread_spectrum_clk_enable */
> --

Applied (with edits in the subject and changelog) as 5.16-rc material, thanks!

\
 
 \ /
  Last update: 2021-12-08 15:31    [W:0.031 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site