Messages in this thread | | | Date | Wed, 8 Dec 2021 19:09:57 +0500 | From | Ameer Hamza <> | Subject | Re: [PATCH v2] net: dsa: mv88e6xxx: error handling for serdes_power functions |
| |
On Wed, Dec 08, 2021 at 07:04:13PM +0500, Ameer Hamza wrote: > mv88e6390_serdes_power() and mv88e6393x_serdes_power() should return > with EINVAL error if cmode is undefined. > > Signed-off-by: Ameer Hamza <amhamza.mgc@gmail.com> > --- > drivers/net/dsa/mv88e6xxx/serdes.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx/serdes.c > index 33727439724a..f3dc1865f291 100644 > --- a/drivers/net/dsa/mv88e6xxx/serdes.c > +++ b/drivers/net/dsa/mv88e6xxx/serdes.c > @@ -830,7 +830,7 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane, > bool up) > { > u8 cmode = chip->ports[port].cmode; > - int err = 0; > + int err; > > switch (cmode) { > case MV88E6XXX_PORT_STS_CMODE_SGMII: > @@ -842,6 +842,8 @@ int mv88e6390_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane, > case MV88E6XXX_PORT_STS_CMODE_RXAUI: > err = mv88e6390_serdes_power_10g(chip, lane, up); > break; > + default: > + return -EINVAL; > } > > if (!err && up) > @@ -1507,7 +1509,7 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane, > bool on) > { > u8 cmode = chip->ports[port].cmode; > - int err = 0; > + int err; > > if (port != 0 && port != 9 && port != 10) > return -EOPNOTSUPP; > @@ -1541,6 +1543,8 @@ int mv88e6393x_serdes_power(struct mv88e6xxx_chip *chip, int port, int lane, > case MV88E6393X_PORT_STS_CMODE_10GBASER: > err = mv88e6390_serdes_power_10g(chip, lane, on); > break; > + default: > + return -EINVAL; > } > > if (err) > -- > 2.25.1 > Hi Marek,
I checked serdes.c and I found two methods mv88e6390_serdes_power() and mv88e6390_serdes_power() that were not returning ENINVAL in case of undefined cmode. Would be appreciated if you can review the patch please.
Best Regards, Ameer Hamza.
| |