Messages in this thread | | | Date | Wed, 8 Dec 2021 13:02:29 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH][V2] intel_th: remove redundant re-assignment of pointer hubdrv |
| |
On Tue, Dec 07, 2021 at 11:07:09PM +0000, Colin Ian King wrote: > The pointer hubdrv is being re-assigned the same value as it was > initialized with only a few lines earlier. The re-assignment is > redundant and can be removed. > > As Dan Carpenter pointed out, the pointer hubdrv is hub - some_offset > and in this case some_offset is zero. Since hub has already been > dereferenced hubdrv can't be NULL so the NULL check is redundant > and can also be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > ---
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |